Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-2774: Do not fail loading files with invalid ID3 image types #2336

Merged
merged 1 commit into from
Oct 10, 2023
Merged

PICARD-2774: Do not fail loading files with invalid ID3 image types #2336

merged 1 commit into from
Oct 10, 2023

Conversation

phw
Copy link
Member

@phw phw commented Oct 10, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Files containing embedded cover art with invalid ID3 image type fail to load.

Solution

Load files even with invalid type. Assume type "other" in this case.

@phw phw requested a review from zas October 10, 2023 05:36
zas
zas approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit eb237c1 into metabrainz:master Oct 10, 2023
69 checks passed
@phw phw deleted the PICARD-2774-invalid-id3-imagetype branch October 10, 2023 14:19
@phw phw mentioned this pull request Jan 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas