Quotes consistency #2326
Quotes consistency #2326
Conversation
|
Not finished, but the idea is to go through all files. I clarified quoting of URIs: basically a quote can theoretically appear in those (single quote is a reserved character for sub delimitation, a bit like |
zas
force-pushed
the
quotes_consistency
branch
from
2116dd7 to
6cdd8f9
Compare
- Add a note about URI & quoting - Add note about XML - Clarify scope and usage if in doubt Clarification
In fact, Python codec is `utf_8` but it has aliases, `utf8' (declared as alias) or `utf-8` (because `_` or `-` do not make difference) are working, but we mainly use `utf-8` among the code. See https://docs.python.org/3/library/codecs.html#standard-encodings
phw
force-pushed
the
quotes_consistency
branch
from
0a630c5 to
511f3be
Compare
|
Merged, but I squashed all the commits that updated the quotes only |
In general, I wouldn't squash such big set of changes, it disables the possibility to bisect. I intentionally split changes in small sets. |
|
In this case it was really a huge amount of separate commits with essentially all the same commit message and with many but trivial changes that causes parser error if done wrong. There was not much point in keeping those. I totally agree in doing changes in multiple commits and I'm not much a friend of squashing all PR as some projects practice it, as any PR that is a bit more complex easily consists of multiple separate steps of implementation. But if each commit is just an extension or fix of the previous one we can keep them combined. |
Summary
Problem
Solution
Action