Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PICARD-2748: Add check for missing profile_id keys #2323

Merged
merged 1 commit into from
Sep 22, 2023
Merged

PICARD-2748: Add check for missing profile_id keys #2323

merged 1 commit into from
Sep 22, 2023

Conversation

rdswift
Copy link
Collaborator

@rdswift rdswift commented Sep 21, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences: Add test for invalid profile_id keys

Problem

See the discussion in PICARD-2748.

Solution

Add checks for invalid keys.

Action

@rdswift rdswift requested review from phw and zas September 21, 2023 20:39
zas
zas approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

phw
phw approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should indeed fix the issue should it occur.

@phw phw merged commit bcb98d6 into metabrainz:master Sep 22, 2023
69 checks passed
@rdswift rdswift deleted the missing_profile_exception branch September 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

@phw phw phw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rdswift @phw @zas