PICARD-2760: Timestamp the Windows binaries when codesigning #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the final binaries are still accepted by the OS even after the certificates have expired.
phw
force-pushed
the
PICARD-2760-windows-codesign-timestamping
branch
from
7822b4f to
1e47319
Compare
This tool is more flexible then the than the Powershell commandlet and unifies code signing between .exe and .appx packages.
phw
force-pushed
the
PICARD-2760-windows-codesign-timestamping
branch
from
1e47319 to
7556986
Compare
|
Tested with the signed binaries on Windows 10 and 11. The binaries now show the timestamp in the file properties:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Enable timestamping when code signing for Windows. Signed binaries with a timestamp will remain valid even after the certificates have expired as long as they get signed before expiration of the certificates.
For details see:
Solution
Use the timestamp server provided by ssl.com with SignTool