Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICARD-1377: New plugin UI icons #2315

Merged
merged 6 commits into from
Sep 19, 2023
Merged

PICARD-1377: New plugin UI icons #2315

merged 6 commits into from
Sep 19, 2023

Conversation

phw
Copy link
Member

@phw phw commented Sep 14, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

Use the new icons designed by @Aerozol for the plugin UI.

Solution

Set the icons. Also add dark UI detection and use a separate set of icons.

Action

@Aerozol The plugins looks really clean and good. But I think the trash can is a bit small, what do you think? Shall we make that a bit larger?

grafik

@rdswift
Copy link
Collaborator

rdswift commented Sep 14, 2023

Once this is implemented, we need to update the images in the documentation at https://picard-docs.musicbrainz.org/en/config/options_plugins.html

@Aerozol
Copy link
Contributor

Aerozol commented Sep 15, 2023

Nice one @phw. How much padding should be in the icon itself was something I wasn’t sure about.
I uploaded bigger ‘trash’ icons into the ticket for you to use :)

@phw
Copy link
Member Author

phw commented Sep 18, 2023

@Aerozol @zas Updated to use the new icons. I also added some extra spacing between the buttons, which makes this UI look cleaner.

grafik

And here a screenshot using the trash bin icon:

grafik

I personally prefer the cross and would go with that (it's also what is currently in the PR). What do you think?

@zas
Copy link
Collaborator

zas commented Sep 18, 2023

I personally prefer the cross and would go with that (it's also what is currently in the PR). What do you think?

No strong preference, but I'm fine with cross

Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aerozol
Copy link
Contributor

Aerozol commented Sep 18, 2023

Looks great! Visually I much prefer the cross, hopefully it doesn’t cause any confusion.

@phw phw merged commit a12aa45 into metabrainz:master Sep 19, 2023
69 checks passed
@phw phw deleted the PICARD-1377 branch September 19, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants