Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CoverArtImage repr #2314

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix CoverArtImage repr #2314

merged 3 commits into from
Sep 14, 2023

Conversation

zas
Copy link
Collaborator

@zas zas commented Sep 14, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

There was a typo leading to potentially incorrect support_multi_types value in __repr__() output.

Solution

Fix the typo, refactor a bit, and add matching tests.

Action

phw
phw previously approved these changes Sep 14, 2023
View reviewed changes
@phw phw self-requested a review September 14, 2023 11:25
phw
phw approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit e2f1940 into metabrainz:master Sep 14, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phw phw phw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zas @phw