Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On plugin import error unset sys.modules again #2310

Merged
merged 1 commit into from
Sep 13, 2023
Merged

On plugin import error unset sys.modules again #2310

merged 1 commit into from
Sep 13, 2023

Conversation

phw
Copy link
Member

@phw phw commented Sep 13, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

pluginmanager sets plugin module in sys.modules, but this should not happen in case of error importing the module.

@phw phw force-pushed the plugin-error-unset-module branch 3 times, most recently from 6d57c8f to ea6982a Compare September 13, 2023 05:49
@phw phw force-pushed the plugin-error-unset-module branch from ea6982a to 6621378 Compare September 13, 2023 05:57
@phw phw requested a review from zas September 13, 2023 06:07
zas
zas approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@zas zas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phw phw merged commit cc59c1d into metabrainz:master Sep 13, 2023
69 checks passed
@phw phw deleted the plugin-error-unset-module branch September 13, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zas zas zas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phw @zas