Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isort fix #2303

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Isort fix #2303

merged 3 commits into from
Sep 7, 2023

Conversation

zas
Copy link
Collaborator

@zas zas commented Sep 7, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

isort 5+ is complaining about missing FIRSTPARTY section in config

Solution

Action

zas added 3 commits September 7, 2023 17:39
Fix following error occuring with isort v5+:

ERROR: Found resources import while parsing, but FIRSTPARTY was not included in the `sections` setting of your config. Please add it before continuing
See https://pycqa.github.io/isort/#custom-sections-and-ordering for more info.
CONTRIBUTING.md Dismissed Show dismissed Hide dismissed
@zas zas marked this pull request as ready for review September 7, 2023 16:30
@zas zas merged commit b100eb1 into metabrainz:master Sep 7, 2023
64 checks passed
@zas zas deleted the isort_fix branch September 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants