Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce method to iterate Qlistwidget items #2302

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

zas
Copy link
Collaborator

@zas zas commented Sep 7, 2023

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Iterating through a QListWidget is quite common in the code, this generator
makes things simpler.
@zas zas requested a review from phw September 7, 2023 12:52
@zas zas force-pushed the qlistwidget_items branch from 41447cb to 6a5bc92 Compare September 7, 2023 13:19
@zas zas changed the title Qlistwidget items Introduce method to iterate Qlistwidget items Sep 7, 2023
@zas zas force-pushed the qlistwidget_items branch from 6a5bc92 to 268eeed Compare September 7, 2023 14:39
@zas zas marked this pull request as ready for review September 7, 2023 15:44
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding.

@zas zas merged commit f15b7f2 into metabrainz:master Sep 7, 2023
64 checks passed
@zas zas deleted the qlistwidget_items branch September 7, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants