Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename id to profile_id where applicable #2300

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Rename id to profile_id where applicable #2300

merged 1 commit into from
Sep 7, 2023

Conversation

zas
Copy link
Collaborator

@zas zas commented Sep 6, 2023

profile_id is explicit.
id() is a built-in function, see https://docs.python.org/3.10/library/functions.html#id

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

@zas
Rename id to profile_id where applicable
9a79fd3 
`profile_id` is explicit.
`id()` is a built-in function, see https://docs.python.org/3.10/library/functions.html#id
@zas zas requested review from rdswift and phw September 6, 2023 21:54
rdswift
rdswift approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@rdswift rdswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense to me. Looks good. Thanks.

@phw phw merged commit 971d88e into metabrainz:master Sep 7, 2023
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdswift rdswift rdswift approved these changes

@phw phw phw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zas @phw @rdswift