Double quote shell variables to prevent globbing and word splitting

metabrainz · Sep 22, 2023 · d47cec4 · d47cec4
1 parent 5e3aee4
commit d47cec4
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/scripts/package/macos-package-app.sh b/scripts/package/macos-package-app.sh
@@ -117,13 +117,13 @@ for i in $(seq $ATTEMPTS); do
     hdiutil create -verbose -volname "MusicBrainz Picard $VERSION" \
       -srcfolder staging -ov -format UDBZ "$DMG"
     ret=$?
-    [ $ret -eq 0 ] && break
+    [ "$ret" -eq 0 ] && break
     echo "hdutil failed with exit code $ret ($i/$ATTEMPTS), retrying in $DELAY seconds"
     sleep $DELAY
 done
-if [ $ret -ne 0 ]; then
+if [ "$ret" -ne 0 ]; then
   echo "hdiutil failed too many times, exiting..."
-  exit $ret
+  exit "$ret"
 fi
 set -e