Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/structs replace jsonvalue #18

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Refactor/structs replace jsonvalue #18

wants to merge 4 commits into from

Conversation

yellowHatpro
Copy link
Collaborator

  • Replaced JsonValue with structs

@RustyNova016
Copy link
Contributor

You may want to remove some of those options. For fields that aren't optional you can just put the type and not have to worry about it being an option ;) (Although you need to be sure they aren't optional, which isn't always clear cough musicbrainz API)

@yellowHatpro
Copy link
Collaborator Author

@RustyNova016 haha, thanks for the suggestion. Sorry I was inactive last week, so couldn't do much. I was doubtful about the types, so I ended up making them all optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yellowHatpro @RustyNova016