Remove conda #294
Open
Remove conda #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
Update build-docs workflow Add cache-dependencies workflow Update cleanup-firebase workflow Update ci workflow Update analyze workflow Update analyze workflow
mogres
force-pushed
the
feature/remove-conda
branch
from
110ea0e to
5c690d3
Compare
rugeli
reviewed
Oct 18, 2024
| 1. Download the installer | ||
|
|
||
| ```bash | ||
| curl -sSLO https://pdm.fming.dev/install-pdm.py |
There was a problem hiding this comment.
In my case, this command didn't trigger the installation, I used the one from the instruction (curl -sSL https://pdm-project.org/install-pdm.py | python3 -) instead, and it worked smoothly.
There was a problem hiding this comment.
This command just downloads the installer. Step 3 in the instructions (python install-pdm.py) runs the downloaded installer and installs pdm. Thanks for checking this!
rugeli
approved these changes
Oct 18, 2024
meganrm
approved these changes
Nov 4, 2024
* Update makefile to move cleanup * Specify base python in tox.ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #293
Solution
Changed the dependency management platform from
condatopyenv+pdmwith @rugeli
Type of change
Change summary:
setup.pypyproject.tomlandpdm.lockpdmfor setup with cacheSteps to Verify:
docs/INSTALL.mdto installcellPACKusingpyenv+pdm.pdm run pytestpack -r cellpack/tests/recipes/v2/test_spheres.jsonMany thanks to Philip Garrison for laying the groundwork for this transition!