-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pass recipe to docker #285
Merged
rugeli
merged 10 commits into
staging/cellpack-server
from
feature/pass-recipe-to-docker
Nov 15, 2024
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6d5f130
draft aws cli inside of docker container
rugeli 807ba73
access aws s3 with saved cred
rugeli 1284bb7
update readme
rugeli ef2f845
update docker commands
rugeli 146ce0f
update readme
rugeli 5406abd
update readme
rugeli 235aed2
add parameter for when we're using docker to default to using the sta…
ascibisz f88286b
read recipe and config in from docker run params
ascibisz 3480a55
use dockerignore file to prevent bloat in docker image
ascibisz cdef941
add `batch_job_id` to result metadata (#295)
rugeli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Distribution / packaging | ||
build/ | ||
develop-eggs/ | ||
eggs/ | ||
.eggs/ | ||
*.egg-info/ | ||
.installed.cfg | ||
*.egg | ||
__pycache__ | ||
|
||
# Unit test / coverage reports | ||
htmlcov/ | ||
.tox/ | ||
.coverage | ||
.coverage.* | ||
.cache | ||
*.cover | ||
cellpack/tests/ | ||
cellpack/bin/tests/ | ||
|
||
# Documentation | ||
docs/ | ||
|
||
# virtualenv | ||
.venv | ||
venv/ | ||
ENV/ | ||
|
||
# Generated data | ||
out/ | ||
*.simularium | ||
**/converted/* | ||
data/ | ||
results/ | ||
|
||
# git | ||
.github/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,20 @@ | ||
#!/bin/bash -e | ||
|
||
# if [ -z "$recipe" ]; then | ||
# echo "Required recipe parameter is missing, please include recipe in Docker run script, ie: -e r=path/to/recipe" | ||
# exit | ||
# fi | ||
|
||
# if [ -z "$config" ]; then | ||
# echo "Required config parameter is missing, please include packing config in Docker run script, ie: -e c=path/to/config" | ||
# exit | ||
# fi | ||
if [ -z "$recipe" ]; then | ||
echo "Required recipe parameter is missing, please include recipe in Docker run script, ie: -e recipe=path/to/recipe" | ||
exit; | ||
else | ||
echo "recipe passed in: '$recipe'" | ||
fi | ||
|
||
cd /cellpack | ||
# pack -r ${recipe} -c ${config} | ||
pack -r examples/recipes/v2/one_sphere.json -c examples/packing-configs/run.json | ||
|
||
if [ -z "$config" ]; then | ||
echo "Config parameter not included, using default value" | ||
pack -r $recipe -d | ||
exit; | ||
else | ||
echo "config passed in: '$config'" | ||
fi | ||
|
||
pack -r $recipe -c $config -d |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this argument name more generic? Seeing as this flag decides the database to use, maybe it could be renamed to
skip_database_check
or something equivalent?