-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: load from s3 #267
Conversation
Add download_file_from_s3 and parse_s3_uri functions Refactor download_file function to handle S3 URLs
…ope/cellpack into refactor/load_from_s3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes! Looks like we still have some merge conflicts, but lmk if I can help with resolving those before merging.
Just rebased this branch with the up-to-date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by packing the url load recipe and works as expected!
Problem
What is the problem this work solves, including
This is a refactor pr for #256, more detailed discussion can be found there
We can merge #256 first and then merge this branch into
main
Solution
What I/we did to solve this problem
download_file_from_s3
fromautopack/__init__.py
toAWSHandler
Type of change
Please delete options that are not relevant.
Steps to Verify: