Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: load from s3 #267

Merged
merged 29 commits into from
Jun 13, 2024
Merged

Refactor: load from s3 #267

merged 29 commits into from
Jun 13, 2024

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Jun 12, 2024

Problem

What is the problem this work solves, including
This is a refactor pr for #256, more detailed discussion can be found there
We can merge #256 first and then merge this branch into main

Solution

What I/we did to solve this problem

  • reorganized aws related function download_file_from_s3 from autopack/__init__.py to AWSHandler
  • adjusted the s3 client initiation

Type of change

Please delete options that are not relevant.

  • Code refactoring (non-breaking change)

Steps to Verify:

  1. Run packing
pack -r cellpack/tests/recipes/v2/test_url_load.json -c cellpack/tests/packing-configs/test_url_load_config.json

Copy link

github-actions bot commented Jun 12, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli rugeli requested review from mogres and meganrm June 12, 2024 20:05
Base automatically changed from feature/load_mesh_from_s3 to main June 13, 2024 16:51
Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes! Looks like we still have some merge conflicts, but lmk if I can help with resolving those before merging.

@rugeli
Copy link
Collaborator Author

rugeli commented Jun 13, 2024

Thanks for making these changes! Looks like we still have some merge conflicts, but lmk if I can help with resolving those before merging.

Just rebased this branch with the up-to-date main and resolved the conflicts, could you take a final look before I merge? Thanks!

@rugeli rugeli requested a review from mogres June 13, 2024 18:34
Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by packing the url load recipe and works as expected!

@rugeli rugeli merged commit 91e18a9 into main Jun 13, 2024
7 checks passed
@rugeli rugeli deleted the refactor/load_from_s3 branch June 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants