-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix github action job: Version 3.9 with arch x64 not found #247
Conversation
Is there any reason we are using Python 3.10 for testing? The base cellpack environment still uses Python 3.9 |
.github/workflows/ci.yml
Outdated
@@ -53,7 +53,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v5 | |||
with: | |||
python-version: 3.9 | |||
python-version: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could define this as a variable that you then reference in the matrix and down here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I just realized sharing values across jobs might require some tweaks, like adding another job to define and output the python version and using needs
in other jobs. The way we have it now looks cleaner.
Because one of our github actions failed, with the error described in the title, it seems that the version of To solve the issue, we can either specify an older We may need to upgrade the base environment to python 3.10 soon to maintain consistency. |
While I do agree we should move to python 3.10 eventually, I am not sure if this is the right approach. The ideal path would be to first create a branch to migrate cellPACK to Python 3.10, check whether this breaks anything beyond our unit tests and then upgrade our CI workflows, requirements, etc. to use the new python version. Another reasoning for sticking with python 3.9 is because the cellPACK package is a dependency in other analysis packages including For the time being, I would recommend using Ubuntu 20.04 in our tests to be compatible with the base cellPACK version. If that is not feasible, we can discuss ways to ensure that the tests are run on the same python version as the base package in one of the WG meetings. |
.github/workflows/ci.yml
Outdated
@@ -80,7 +80,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v1 | |||
with: | |||
python-version: 3.9 | |||
python-version: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the setup-python version here might also be useful
Added a suggestion comment for this here
I see your concern, sure I'll try a different approach and we can discuss it at our next meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe updating the setup-python version would help?
.github/workflows/ci.yml
Outdated
@@ -80,7 +80,7 @@ jobs: | |||
- name: Set up Python | |||
uses: actions/setup-python@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses: actions/setup-python@v1 | |
uses: actions/setup-python@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are absolutely right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Merge this pr first
Problem
What is the problem this work solves, including
CI/CD issue:
Error: Version 3.9 with arch x64 not found
Solution
What I/we did to solve this problem
Made a few adjustments, and turns out using python 3.10 - currently the most stable version for cellPACK.updated
checkout
andsetup-python
Type of change
Please delete options that are not relevant.