Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unused analysis functions #246

Merged
merged 15 commits into from
Jun 7, 2024
Merged

Move unused analysis functions #246

merged 15 commits into from
Jun 7, 2024

Conversation

mogres
Copy link
Collaborator

@mogres mogres commented May 8, 2024

Problem

Closes #225

Solution

Move unused functions to utils.py

Type of change

Maintenance

Change summary:

  • Moved some unused analysis functions to utils.py
  • Moved functions related to spilr to the cellpack-analysis repository

Steps to Verify:

Packing using the Analysis workflow run as expected

Keyfiles:

  1. Analysis.py

Copy link

github-actions bot commented May 8, 2024

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@mogres mogres requested review from meganrm and rugeli May 8, 2024 20:05
cellpack/autopack/utils.py Outdated Show resolved Hide resolved
cellpack/autopack/utils.py Outdated Show resolved Hide resolved
cellpack/autopack/utils.py Outdated Show resolved Hide resolved
@mogres
Copy link
Collaborator Author

mogres commented May 13, 2024

@meganrm, almost all of the moved functions are unused so they may have references to non-existent class objects etc.
My idea was to move functions to utils.py to keep around as backup if needed in the future, but I am also happy to delete them if that makes more sense. We can always restore them from the git history if required.

@mogres mogres marked this pull request as draft May 14, 2024 22:19
@mogres
Copy link
Collaborator Author

mogres commented May 28, 2024

@meganrm removed the functions from utils

@mogres mogres marked this pull request as ready for review May 28, 2024 22:56
Copy link
Collaborator

@rugeli rugeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the code is much cleaner!

@mogres mogres requested a review from meganrm June 3, 2024 19:47
@mogres mogres merged commit a506867 into main Jun 7, 2024
7 checks passed
@mogres mogres deleted the feature/move_analyses branch June 7, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move unused analysis code to cellpack-analysis repository
3 participants