Feature/upload local recipes to s3 #189
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 16 16
Lines 476 476
=======================================
Hits 469 469
Misses 7 7 ☔ View full report in Codecov by Sentry. |
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
|
This PR focuses on uploading local recipes to S3 and is ready for prioritized merging after review. The database handler import issue has taken longer to resolve than anticipated, so I'll keep working on the Once we all agree on the solution for database handler initiation and all related PRs are merged, I'll resume work on uploading remote recipes to S3 and storing metadata to firebase. Thanks! |
| simulariumHelper.open_in_simularium(url) | ||
|
|
||
| @staticmethod | ||
| def store_results_to_s3(file_path): |
There was a problem hiding this comment.
I might consider moving more of this into the handler. so in this file all you have to do is call url = AWSHandler(OPTIONS).save_file(file_path) and everything is handled by the other file
| try: | ||
| url = simulariumHelper.store_results_to_s3(simularium_file) | ||
| except Exception as e: | ||
| aws_readme_url = "https://github.com/mesoscope/cellpack/blob/feature/main/README.md#aws-s3" |
There was a problem hiding this comment.
This is helpful, thanks for adding it in!
Problem
What is the problem this work solves, including
Partially closing #140
Solution
What I/we did to solve this problem
simularium_helper.pyto:- store local results to S3 path:
cellpack-results/simularium- enable automatically opened packing results on Simularium
Note: a separate PR will handle the upload of metadata to firebase
Type of change
Please delete options that are not relevant.
Steps to Verify:
pack -r cellpack/tests/recipes/v2/test_spheres.json -c examples/packing-configs/sparse-packing.jsonKeyfiles (delete if not relevant):
simularium_helper.pyAWSHandler.py