Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add dependabot #1203

Merged
merged 2 commits into from
Oct 2, 2023
Merged

github: add dependabot #1203

merged 2 commits into from
Oct 2, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Sep 27, 2023

Bot to update CI.

This will update at least actions/checkout on merge.

@eli-schwartz
Copy link
Member

There's nothing to do here, it accomplishes zero things of value. I also generally object to dependabot because it's absolutely horrible around batching PRs.

If we were to use anything it should be renovate-bot, which is well behaved in large part because it is also open source. But I don't really think we should do anything.

@neheb
Copy link
Collaborator Author

neheb commented Sep 27, 2023

git grep uses: | cut -d ':' -f 3 | sort
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 actions/checkout@v3
 ilammy/msvc-dev-cmd@v1
 ilammy/msvc-dev-cmd@v1
 ilammy/msvc-dev-cmd@v1
 ilammy/msvc-dev-cmd@v1
 msys2/setup-msys2@v2
 msys2/setup-msys2@v2

are subject to update.

@eli-schwartz
Copy link
Member

My understanding is that the only thing that major version updates for actions/checkout actually changes is the internal nodejs version, which is the biggest fattest nothingburger ever. The previous major release is still fully supported with the same new features because there's rarely ever breaking changes, GitHub just considers the internal nodejs version to be a breaking change because GitHub Enterprise customers would need to update their deployment to new Actions runners.

@neheb
Copy link
Collaborator Author

neheb commented Sep 27, 2023

Meh. Guess I'll manually do it.

@eli-schwartz
Copy link
Member

My question isn't about whether there are things "subject to update", but rather "are there ever updates of substance".

What are we updating manually other than a nodejs internal version?

Instead of cloning shallow and then unshallowing. Should speed it up
slightly.

Signed-off-by: Rosen Penev <[email protected]>
Proactive update to avoid deprecation warnings later on.

Signed-off-by: Rosen Penev <[email protected]>
@neheb
Copy link
Collaborator Author

neheb commented Sep 27, 2023

@eli-schwartz reworked PR. Please review.

@neheb neheb merged commit 5fd940a into mesonbuild:master Oct 2, 2023
7 checks passed
@neheb neheb deleted the dep branch October 2, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants