Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gumbo-parser: update to 0.12.1 #1198

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

benoit-pierre
Copy link
Contributor

Note:

  • switch to new maintained fork (also used by Arch Linux )
  • currently broken on MSVC because visualc/include/strings.h was removed

@txgk: can visualc/include/strings.h be added back? I would have opened an issue on codeberg, but registrations are disabled… (I also can contribute the port to meson if you're interested, BYTW)

@txgk
Copy link

txgk commented Sep 24, 2023

@txgk: can visualc/include/strings.h be added back?

Hello, yes of course. I deleted it earlier because I thought that no one needed it, but since it has value still, let's return it. After 0.12.0 there were several good fixes, so I immediately released it, so just change the version to 0.12.1 and visualc/include/strings.h file will be back in place.

I would have opened an issue on codeberg, but registrations are disabled…

Very strange. I guess they are testing something...

I also can contribute the port to meson if you're interested, BYTW

I think it'd be better to stay with autotools for now to keep the gap between new and old repositories smaller (that way we'll save maintainers a good chunk of time I believe).

@benoit-pierre benoit-pierre changed the title gumbo-parser: update to 0.12.0 gumbo-parser: update to 0.12.1 Sep 24, 2023
@benoit-pierre
Copy link
Contributor Author

@txgk: can visualc/include/strings.h be added back?

Hello, yes of course. I deleted it earlier because I thought that no one needed it, but since it has value still, let's return it. After 0.12.0 there were several good fixes, so I immediately released it, so just change the version to 0.12.1 and visualc/include/strings.h file will be back in place.

Thanks.

I would have opened an issue on codeberg, but registrations are disabled…

Very strange. I guess they are testing something...

Too much spam, apparently… ¯\(ツ)

I also can contribute the port to meson if you're interested, BYTW

I think it'd be better to stay with autotools for now to keep the gap between new and old repositories smaller (that way we'll save maintainers a good chunk of time I believe).

Sure, I understand.

@neheb neheb merged commit b01632c into mesonbuild:master Sep 25, 2023
7 checks passed
@benoit-pierre benoit-pierre deleted the pr/update_gumbo-parser branch September 25, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants