{libopenjp2,libxml2,sqlite3}: don't link with pthreads on Windows #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neheb
reviewed
Sep 23, 2023
SQLite uses the Windows threading primitives directly, so linking with -pthread is unnecessary.
libxml2 can use the Windows threading primitives directly. Use those if available, rather than taking a dependency on winpthreads.
OpenJPEG uses the Windows threading primitives directly, so linking with -pthread is unnecessary. Also stop defining both MUTEX_win32 and MUTEX_pthread on Windows.
|
If I had to guess, more packages have this problem. Good enough here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libopenjp2 and sqlite3 were configured to use the Win32 threading primitives on Windows, but were being linked with
-pthreadanyway. Stop doing that. For libopenjp2, we were defining bothMUTEX_win32andMUTEX_pthread; stop doing that too.libxml2 can use the Win32 primitives, but was taking a dependency on winpthreads instead. Switch to the Win32 primitives.