App intents #859
App intents #859
Conversation
|
Phenomenal work, Ben! |
|
Can you make a branch in the repo and not on your personal account? |
| @@ -11,6 +11,7 @@ import OSLog | |||
| // Meshtastic BLE Device Manager | |||
| // --------------------------------------------------------------------------------------- | |||
| class BLEManager: NSObject, CBPeripheralDelegate, MqttClientProxyManagerDelegate, ObservableObject { | |||
| static var shared: BLEManager! // Singleton instance | |||
There was a problem hiding this comment.
I have some long-term testability concerns about making BLEManager a Singleton.
Could we use @Environment and dependency injection to the places where it's used instead?
There was a problem hiding this comment.
@72A12F4E IMO something needs to be done about BLEManager being transient though. For instance, currently the Share Location functionality is capable of spinning up multiple timers during consecutive connect / disconnect cycles because of the lifecycle of that BLEManager object.
To repro: Take a device with location sharing on the default interval, connect and disconnect multiple times in succession.
There was a problem hiding this comment.
Perhaps the timer stuff needs to be up an abstraction layer? Not sure what the idiomatic way of doing this is
…cimals Match the firmware and do 3 decimal points for decimals
App intents closes meshtastic#33
Created Error handling and a new Node Position Intent
|
Closing in favor of #866 |
What changed?
Modified the BLEManager class to make it a singleton to access from anywhere. Added two App Intents: Channel Message and Send Waypoint
Why did it change?
Allowing users to utilize apple shortcuts to greatly customize their Meshtastic experience. Example: a custom weather-sending bot built with no coding experience and just iOS shortcuts. Also will enable Siri functionality and widgets for future development.
How is this tested?
I tested sending waypoints from the shortcut on my phone and tested sending messages. The normal functionality of ble works after my BLEManager change
Screenshots/Videos (when applicable)
Checklist