-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for navigating to currently connected node info #837
Add support for navigating to currently connected node info #837
Conversation
|
Wondering if we should nav to node details instead? From an IA perspective, this interaction id similar to tapping a node in the node list. Curious what others think here. |
I would agree with you. I like the concept here but I also think it should go to the node details page rather than directly to the device metrics. |
Here's a question then, how would you feel about adding current battery, channel utilization, and airtime as values to the node details screen if that node is your currently connected node (or even for all nodes, but that's less important imho)? Then, in this case that I'm trying to optimize for, there'd be no need to navigate to device metrics at all and node details would have everything important about your current device at a glance. |
I'm a fan of the current setup. I don't mind making it easier to get to that information with less taps, but I don't think there needs to be a redesign of how the information is currently displayed. I feel like what's currently on the node list page for the connected device is the most at-a-glance info I need. |
Got it. I honestly just want to see my battery status without navigation diving :) Right now, device metrics seems to be the only way to get that information. So maybe separately there can be some brainstorming of how this value might be surfaced. |
Maybe it can be as simple as adding the battery level of the connected device there on the BLE screen? |
It now navigates to Node Info. RPReplay_Final1722637661.mp4 |
Love that. I'll file something separately for changing that. |
Yeah this seems pretty confusing and not really necessary, the nav needs to be finished and then we can look at the value of some of this linking back and forth. |
The details on the new navigation structures are here, eventually it should be pretty easy to build all sorts of custom shortcuts for things like this #857 |
No pressure to accept this PR if it doesn't make sense or I'm overlooking something obvious.
Closes #836
This PR adds support for navigating to the currently connected node info screen directly from the bluetooth radio screen
by tapping on the connected radio.
It adds a small right pointing chevron after the radio is connected to show that tapping on it will navigate somewhere.
What changed?
Updated
Connect.swift
to support navigating to the device node info screen.Why did it change?
To add a level of convenience to getting to your currently connected device's details.
How is this tested?
It was tested with my local node on iOS hardware.
Screenshots/Videos (when applicable)
Untitled.mp4
Checklist