Bluetooth reconnect fix android15 #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we trap code 147 on BT disconnect and then call lostConnection(), the app will attempt reconnect every 30 seconds and autoreconnect works even after prolonged disconnect.
This was referenced Dec 13, 2024
Closed
|
Thank you. Perhaps a on/off button and/or reconnect timeout set (30 sec - 300 sec) would be a good idea. Great work. |
|
I just tested these changes on a Pixel 3 - Android 12 - API 31 and it doesn't effect its ability to reconnect. |
andrekir
requested changes
Dec 15, 2024
| @@ -259,7 +259,7 @@ class RadioInterfaceService @Inject constructor( | |||
| * @return true if the device changed, false if no change | |||
| */ | |||
| private fun setBondedDeviceAddress(address: String?): Boolean { | |||
| return if (getBondedDeviceAddress() == address && isStarted) { | |||
| return if (getBondedDeviceAddress() == address && isStarted && isConnected) { | |||
There was a problem hiding this comment.
This is intended behavior. We specifically track isStarted just for this call. Please revert this change, and it should be good to merge.
This reverts commit 27b1e4d.
andrekir
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull fixes two issues.