Time breaks #1456
Merged
Time breaks #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a significant break in time.
|
I like this. On the one hand, I feel like it would be nice to have it draw lines in between those gaps so it kind of guesses dead-reckoning-style, but on the other hand I actually think the gaps there makes it much more obvious that there wasn't just linear data points and that there actually isn't data for those times. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Feature: Drawing the battery line only when the data is continuous with out a large time separation.Refactor: Wrote helper functions to help plot data points and draw lines.Demo
TimeBreakDemo.mp4