-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Device Hardware json and svg graphics #1449
Conversation
Allows for better hardware device display names, graphics, and indication of support.
b212cb0
to
bef7e7a
Compare
Use the first image name from the `images` list (after removing the ".svg" suffix) to find the corresponding vector drawable resource.
Please move the images from the detail section to a header at the top of the screen. The header should place the image in focus without overwhelming the rest of the screen, so it also needs to work well with both horizontal and vertical images. Maybe use a complementary background with the hardware name under the image. |
Updated the device detail layout to group device-specific information under a "Device" category. Added a circular background with device-specific color behind the device icon. Moved hardware, support status details to the Device section.
@andrekir - i moved the relevant device info up to a new |
Moves the logic for retrieving device hardware information and image resources from NodeDetail to MetricsViewModel. Also replaces id lookup with when statement for image resource id mapping.
@andrekir - I moved the DeviceHardware and image res functions to MetricsViewModel, and added some State variables. The DeviceHardware json parsing now has exception handling and is cached in the model to avoid expensive rereads. I also updated the image res function to use |
Adds device_hardware.json, DeviceHardware model, svg device graphics, and convenience methods to parse the json and map it to DeviceHardware model and image resource.
Allows for better hardware device display names, graphics, and indication of support.