-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI]: Meshery extension catalog modal image height fix #1882
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ankita Sahu <[email protected]>
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @SAHU-01.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SAHU-01 few snapshots images is streched out . Is this due to this change? I think yes!
@SAHU-01, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. |
Yes, I'll check these and fix it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SAHU-01 will you remove the unnecessary added lines , the lint changes.
Sure I'll get rid of the linting changes. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
@SAHU-01, just a reminder in case you missed this. |
@SAHU-01 ? |
@vishalvivekm thank you for highlighting this, I'll remove the unecessary linting changes . |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
This PR fixes #1881
Notes for Reviewers
I've resolved this by adding a
height:100%
to the image tag CSSSigned commits