-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update graphql-upload
#5
Conversation
"mercurius": "^8.11.2", | ||
"prettier": "^2.5.1", | ||
"tap": "^15.1.5", | ||
"ts-node": "^10.4.0", | ||
"typescript": "^4.5.3" | ||
}, | ||
"peerDependencies": { | ||
"graphql": "0.13.1 - 16" | ||
"graphql": "^16.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
/destroy/1.0.4: | ||
resolution: {integrity: sha1-l4hXRCxEdJ5CBmE+N5RiBYJqvYA=} | ||
dev: true | ||
|
||
/dicer/0.3.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main motivation for the upgrade is to get rid of this
Ugh, the changed exports are absolutely horrendous to deal with (at least to get TS to work: jaydenseric/graphql-upload#282)... |
seems to work now, but the other 2 PRs should land first to make the diff here readable |
|
||
/* https://github.com/jaydenseric/graphql-upload/issues/282#issuecomment-1142691771 */ | ||
"allowJs": true, | ||
"maxNodeModuleJsDepth": 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can drop the changes to tsconfig.json
if jaydenseric/graphql-upload#317 is accepted
#8 it seems to be working here, I basically rebased, fixed conflict and updated lockfile |
feel free to do the same changes 👍 |
7afa597
to
e6698ff
Compare
e6698ff
to
ef93932
Compare
either pnpm or GH seems to have issues atm, but I rebased this now 👍 |
it was some rare gh actions issues, now it's working |
|
To pull in an updated
busboy
which avoids a vulnerabledicer
, see https://github.com/jaydenseric/graphql-upload/releases/tag/v15.0.0Both updates minimum
graphql
andnode
, so this is a breaking change