Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update graphql-upload #5

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

SimenB
Copy link

@SimenB SimenB commented Jun 1, 2022

To pull in an updated busboy which avoids a vulnerable dicer, see https://github.com/jaydenseric/graphql-upload/releases/tag/v15.0.0

Both updates minimum graphql and node, so this is a breaking change

"mercurius": "^8.11.2",
"prettier": "^2.5.1",
"tap": "^15.1.5",
"ts-node": "^10.4.0",
"typescript": "^4.5.3"
},
"peerDependencies": {
"graphql": "0.13.1 - 16"
"graphql": "^16.3.0"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/destroy/1.0.4:
resolution: {integrity: sha1-l4hXRCxEdJ5CBmE+N5RiBYJqvYA=}
dev: true

/dicer/0.3.0:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main motivation for the upgrade is to get rid of this

@SimenB
Copy link
Author

SimenB commented Jun 1, 2022

Ugh, the changed exports are absolutely horrendous to deal with (at least to get TS to work: jaydenseric/graphql-upload#282)...

@SimenB SimenB marked this pull request as draft June 1, 2022 08:03
This was referenced Jun 1, 2022
@SimenB
Copy link
Author

SimenB commented Jun 1, 2022

seems to work now, but the other 2 PRs should land first to make the diff here readable


/* https://github.com/jaydenseric/graphql-upload/issues/282#issuecomment-1142691771 */
"allowJs": true,
"maxNodeModuleJsDepth": 10
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop the changes to tsconfig.json if jaydenseric/graphql-upload#317 is accepted

@PabloSzx
Copy link
Member

#8 it seems to be working here, I basically rebased, fixed conflict and updated lockfile

@PabloSzx
Copy link
Member

#8 it seems to be working here, I basically rebased, fixed conflict and updated lockfile

feel free to do the same changes 👍

@SimenB SimenB force-pushed the update-graphql-upload branch from 7afa597 to e6698ff Compare June 13, 2022 10:31
@SimenB SimenB marked this pull request as ready for review June 13, 2022 10:33
@SimenB SimenB force-pushed the update-graphql-upload branch from e6698ff to ef93932 Compare June 13, 2022 10:33
@SimenB
Copy link
Author

SimenB commented Jun 13, 2022

either pnpm or GH seems to have issues atm, but I rebased this now 👍

@PabloSzx
Copy link
Member

it was some rare gh actions issues, now it's working

@PabloSzx PabloSzx merged commit 20af57f into mercurius-js:master Jun 13, 2022
@SimenB SimenB deleted the update-graphql-upload branch June 13, 2022 15:07
@SimenB
Copy link
Author

SimenB commented Jun 13, 2022

it was some rare gh actions issues, now it's working

Yeah, https://www.githubstatus.com/incidents/6r4sms3hcj3x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants