Skip to content

Commit

Permalink
Update golangci-lint version (1.41.1 -> 1.50.0). Enable dupword linter (
Browse files Browse the repository at this point in the history
  • Loading branch information
oscr authored Nov 12, 2022
1 parent bf6a0ff commit fa67deb
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ linters:
- gofmt
- goheader
- govet
- dupword
linters-settings:
goheader:
template: |
Expand Down
2 changes: 1 addition & 1 deletion hack/check_golangci-lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

set -e

GOLANGCILINT_VERSION="1.41.1"
GOLANGCILINT_VERSION="1.50.0"
GOLANGCILINT_FILENAME="golangci-lint-${GOLANGCILINT_VERSION}-linux-amd64.tar.gz"
GOLANGCILINT_URL="https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCILINT_VERSION}/${GOLANGCILINT_FILENAME}"

Expand Down
2 changes: 1 addition & 1 deletion pkg/metrics/cinder.go
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ func publishVolumeMetrics(v volumes.Volume, pv *corev1.PersistentVolume) {
k8sMetadata := extractK8sMetadata(pv)

// add the k8s specific labels.
// We do not need need to check them, because the empty string is totally fine.
// We do not need to check them, because the empty string is totally fine.
labels = append(labels, k8sMetadata...)

// set the volume-specific metrics
Expand Down

0 comments on commit fa67deb

Please sign in to comment.