MEN-4813: avoid race condition when aborting deployments #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mender-test-bot start pipeline |
|
@tranchitella, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". |
|
Hello 😸 I created a pipeline for you here: Pipeline-329028279 Build Configuration Matrix
|
If the user aborts a deployment while devices are updating their status, it can happen a stats recalculation is performed in parallel with the abort operation. In this case, deployment's end time is set but the status is not "finished", making it impossible to abort the deployment. Changelog: none Signed-off-by: Fabio Tranchitella <[email protected]>
|
@mender-test-bot start pipeline |
|
Hello 😸 I created a pipeline for you here: Pipeline-329068268 Build Configuration Matrix
|
kjaskiewiczz
approved these changes
Jun 30, 2021
alfrunes
reviewed
Jun 30, 2021
alfrunes
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user aborts a deployment while devices are updating their status,
it can happen a stats recalculation is performed in parallel with the
abort operation. In this case, deployment's end time is set but the
status is not "finished", making it impossible to abort the deployment.
Changelog: none
Signed-off-by: Fabio Tranchitella [email protected]