Small corrections for Bin and Dynamic Pads code examples #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested changes
Jun 24, 2024
Comment on lines
44
to
45
| demand_unit: :buffers, | ||
| flow_control: :pull, |
There was a problem hiding this comment.
flow_control: :pull with demand_mode: :manual (the old default) became flow_control: :manual
flow_control: :pull with demand_mode: :auto became flow_control: :auto (the new default)
Input pads with flow_control: :manual always have to specify demand_unit explicitly
Suggested change
| demand_unit: :buffers, | |
| flow_control: :pull, | |
| demand_unit: :buffers, | |
| flow_control: :manual, |
FelonEkonom
approved these changes
Jun 25, 2024
|
Thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted as I was going through this area of the tutorial. It looks like
tobecamechildandpullbecameauto(and the default value).