Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update basic_pipeline_extension tutorial #90

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Update basic_pipeline_extension tutorial #90

merged 1 commit into from
Jan 2, 2024

Conversation

varsill
Copy link
Collaborator

@varsill varsill commented Dec 22, 2023

This PR:

  • updates basic_pipeline_extension tutorial to use Core v1.0
  • removes the dependency to the template/bin branch of the membrane_basic_pipeline_tutorial repository as it is deprecated now
  • fixes some minor leftovers from old Core's API in basic_pipeline tutorial (e.g. handle_init/1 instead of handle_init/2)
  • changes the tutorials' names in the index.md files from How to setup basic pipeline into All you need to know about pipelines

@varsill
Update
be0deb6 
basic_pipeline_extension tutorial to use Core v1.0. Remove dependency to the template/bin branch of the membrane_basic_pipeline_tutorial repository as it is deprecated now. Fix some minor leftovers from old Core's API in basic_pipeline tutorial (e.g. handle_init/1 instead of handle_init/2).
@varsill varsill requested a review from mat-hek December 22, 2023 09:31
mat-hek
mat-hek approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@mat-hek mat-hek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅ I have two things to possibly consider in this or another PR

  • The directory name (basic_pipeline) is reflected in the tutorial URL, so I'd change it as well
  • I'm not sure why this tutorial is split into two parts. Maybe we can merge them?

@varsill varsill merged commit ce25f4d into main Jan 2, 2024
1 check passed
@varsill varsill deleted the update_basic_pipeline_extension_to_v1_0 branch January 2, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek mat-hek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varsill @mat-hek