Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic tutorial v1.0 #88

Merged
merged 18 commits into from
Dec 22, 2023
Merged

Basic tutorial v1.0 #88

merged 18 commits into from
Dec 22, 2023

Conversation

kidq330
Copy link
Collaborator

@kidq330 kidq330 commented Dec 6, 2023

No description provided.

@kidq330 kidq330 marked this pull request as ready for review December 6, 2023 15:03
@varsill varsill mentioned this pull request Dec 8, 2023
Closed
varsill
varsill requested changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@varsill varsill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, good to see the tutorial getting in shape ;)
There is one bigger issue (with accepted stream format definition) and some smaller ones.

basic_pipeline/03_Source.md Outdated Show resolved Hide resolved
basic_pipeline/03_Source.md Outdated Show resolved Hide resolved
basic_pipeline/03_Source.md Outdated Show resolved Hide resolved
basic_pipeline/05_Formats.md Outdated Show resolved Hide resolved
basic_pipeline/07_Redemands.md Outdated Show resolved Hide resolved
basic_pipeline/11_Pipeline.md Outdated Show resolved Hide resolved
basic_pipeline/11_Pipeline.md Outdated Show resolved Hide resolved
basic_pipeline/11_Pipeline.md Outdated Show resolved Hide resolved
basic_pipeline/04_StreamFormat.md Outdated Show resolved Hide resolved
basic_pipeline/09_Mixer.md Outdated Show resolved Hide resolved
@kidq330 kidq330 requested a review from varsill December 20, 2023 09:46
varsill
varsill reviewed Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@varsill varsill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so as discussed - I will update the part of text about accepted stream format and redemands, let you read it and then we will merge ;)

kidq330
kidq330 commented Dec 21, 2023
View reviewed changes
Copy link
Collaborator Author

@kidq330 kidq330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

basic_pipeline/07_Redemands.md Outdated Show resolved Hide resolved
basic_pipeline/07_Redemands.md Outdated Show resolved Hide resolved
@kidq330 kidq330 requested a review from varsill December 21, 2023 14:24
@varsill varsill merged commit 030a4a0 into main Dec 22, 2023
@varsill varsill deleted the basic_tutorial_v1.0 branch December 22, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-hek mat-hek Awaiting requested review from mat-hek

@varsill varsill Awaiting requested review from varsill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kidq330 @varsill