refactor soundwave livebook #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varsill
reviewed
Feb 13, 2024
livebooks/soundwave/soundwave.livemd
Outdated
Comment on lines
147
to
148
| Kino.render(chart) | ||
| chart |
There was a problem hiding this comment.
[NIT] It should be fine as Kino.render/1 returns the chart
Suggested change
| Kino.render(chart) | |
| chart | |
| Kino.render(chart) |
| for <<sample::binary-size(state.bytes_per_sample) <- buffer.payload>> do | ||
| RawAudio.sample_to_value(sample, ctx.pads.input.stream_format) | ||
| for <<sample::binary-size(sample_size) <- buffer.payload>> do | ||
| RawAudio.sample_to_value(sample, stream_format) / sample_max |
There was a problem hiding this comment.
Shouldn't it be more like:
Suggested change
| RawAudio.sample_to_value(sample, stream_format) / sample_max | |
| RawAudio.sample_to_value(sample, stream_format) / (sample_max-sample_min) |
?
(I am a little bit worried it won't get rescaled properly in case we have a signed number as a sample value)
There was a problem hiding this comment.
I think PortAudio returns signed numbers by default. sample_max is around 2^15 and sample_min is around -(2^15), so by dividing by sample_max we're getting [-1, 1]. After the proposed change, I think we'd get [-0.5, 0.5] 🤔
varsill
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.