Generate warnings related to pads with :auto flow control
#900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
added
the
no-changelog
FelonEkonom
changed the title
:auto flow control
mat-hek
requested changes
Oct 29, 2024
There was a problem hiding this comment.
I'm not sure that warnings are the best way to inform a user about behaviour that may be completely desired. IMO warnings should indicate that even though something won't necessarily break, it's definitely wrong, which is not the case here. That said, I have no idea for a better way to solve this :P
mat-hek
reviewed
Nov 8, 2024
| env.module | ||
| |> Module.get_attribute(:__membrane_element_type__, :bin) | ||
| |> case do | ||
| :bin -> Membrane.Bin |
There was a problem hiding this comment.
shouldn't this apply to elements only?
lib/membrane/endpoint.ex
Outdated
| @@ -25,6 +25,9 @@ defmodule Membrane.Endpoint do | |||
|
|
|||
| Options: | |||
| - `:bring_pad?` - if true (default) requires and aliases `Membrane.Pad` | |||
| - `:flow_control_related_warnings?` - if true (default) generates compile-time warnings \ | |||
There was a problem hiding this comment.
What about
Suggested change
| - `:flow_control_related_warnings?` - if true (default) generates compile-time warnings \ | |
| - `:flow_control_hints?` - if true (default) generates compile-time warnings \ |
mat-hek
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #868
Closes #869