Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue in example - README.md #57

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

Liferenko
Copy link
Contributor

@Liferenko Liferenko commented Apr 4, 2024

Hello!

Seems like README's "Decoder" example is not working as-is.
Error message:

Evaluation process terminated - an exception was raised:
    ** (Membrane.ActionError) Error while handling action {:playback, :playing}
We looked everywhere, but couldn't find out what this action is supposed to do.
Make sure it's correct and valid for the component, its playback, callback or
other possible circumstances. See the docs for Membrane.Pipeline.Action to check
which actions are supported and when you can return them.


        (membrane_core 1.0.1) lib/membrane/core/pipeline/action_handler.ex:104: Membrane.Core.Pipeline.ActionHandler.handle_action/4
        (membrane_core 1.0.1) lib/membrane/core/callback_handler.ex:197: anonymous fn/5 in Membrane.Core.CallbackHandler.handle_callback_result/5
        (elixir 1.15.7) lib/enum.ex:2510: Enum."-reduce/3-lists^foldl/2-0-"/3
        (membrane_core 1.0.1) lib/membrane/core/callback_handler.ex:195: Membrane.Core.CallbackHandler.handle_callback_result/5
        (membrane_core 1.0.1) lib/membrane/core/pipeline.ex:64: Membrane.Core.Pipeline.init/1
        (stdlib 5.1.1) gen_server.erl:962: :gen_server.init_it/2
        (stdlib 5.1.1) gen_server.erl:917: :gen_server.init_it/6
        (stdlib 5.1.1) proc_lib.erl:241: :proc_lib.init_p_do_apply/3

For new developers it might take a bit of time to figure out that the example works without playback: :playing in handle_init/2 response.
Tested both in Livebook and IEx

Short demo "Before/after": https://youtu.be/m3ie7b7ccQc

seems like it works (tested in Liveview) without `playback: :playing`
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delay, we had to somehow omit your PR. Thank you for the contribution 👍

README.md Outdated Show resolved Hide resolved
@FelonEkonom FelonEkonom self-assigned this Apr 16, 2024
@FelonEkonom FelonEkonom added the bug Something isn't working label Apr 16, 2024
Co-authored-by: Feliks Pobiedziński <[email protected]>
@FelonEkonom FelonEkonom self-requested a review April 16, 2024 13:21
@FelonEkonom FelonEkonom merged commit 04a3ff1 into membraneframework:master Apr 16, 2024
@Liferenko Liferenko deleted the patch-1 branch April 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants