V0.18 #53
Merged
V0.18 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
requested changes
Jan 22, 2024
Comment on lines
86
to
93
| ], | ||
| input_stream_format: [ | ||
| spec: RawAudio.t(), | ||
| type: :stream_format, | ||
| default: nil, | ||
| description: """ | ||
| Input type - used to set input sample rate and channels. | ||
| """ |
There was a problem hiding this comment.
def_options is used to define options passed in spec, eg. child(:source, %Source{option: value}). There is no need to put input_stream_format here, because it won't be passed in spec, it is just another field in state
Comment on lines
280
to
295
| defp validate_pts_integrity(true = _check_pts_integrity?, encoded_buffers, input_pts) do | ||
| cond do | ||
| length(encoded_buffers) >= 2 and Enum.at(encoded_buffers, 1).pts > input_pts -> | ||
| Membrane.Logger.warning("PTS values are overlapping") | ||
|
|
||
| length(encoded_buffers) >= 2 and Enum.at(encoded_buffers, 1).pts < input_pts -> | ||
| Membrane.Logger.warning("PTS values are not continous") | ||
|
|
||
| true -> | ||
| :ok | ||
| end | ||
| end | ||
|
|
||
| defp validate_pts_integrity(_check_pts_integrity?, _packets, _input_pts) do | ||
| :ok | ||
| end |
There was a problem hiding this comment.
Refactor this function according to the suggestion from membraneframework/membrane_opus_plugin#59 (comment) (update conditions in cond and remove first argument)
FelonEkonom
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.