Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Add headers exchange type #260

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

gordoneliel
Copy link

Adds headers exchange type when declaring an exchange

Description

GenRMQ currently supports the 3 predefined exchange types on AMPQ, but its missing the "headers" exchange type. This PR adds

Checklist

  • [] I have added unit tests to cover my changes.
  • [] I have improved the code quality of this repo. (refactoring, or reduced number of static analyser issues)
  • [] I have updated the documentation accordingly

@vorce
Copy link
Collaborator

vorce commented Feb 3, 2023

Thanks for the contribution @gordoneliel !

Can you add :headers to@type exchange_kind as well please?

@gordoneliel
Copy link
Author

@vorce Added the headers spec and a test for the headers exchange type! Let me know if you need any more changes,thanks.

@gordoneliel
Copy link
Author

@vorce Dont mean to pressure, but any chance you can take a peek at this? Happy to make any more changes 😁

@vorce
Copy link
Collaborator

vorce commented May 7, 2023

@gordoneliel yo, thanks for the patience and apologies for the terrible turn around time. I think the PR looks good!

Looks like we have to fix the CI setup (again) though.

@mkorszun Hey, please have a look at the MR, I think it's ready to merge. I want to take a look at the CI setup and maybe chuck a PR for that, but if someone else gets to it before me all the better 😬

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants