Add support for using the solar sensor without requiring a Boktai ROM #2221
+134
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Each game in the trilogy has a different effect on Lunar Knights (the only commercial DS game to support the solar sensor)
# Conflicts: # src/GBACart.cpp # src/GBACart.h
JesseTG
changed the title
|
Whoops, I'd forgotten that I already added UI support. In that case, this PR is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an API to the emulator that creates a stub ROM with just enough information to convince Lunar Knights that a solar sensor cart is inserted, allowing players to use the solar sensor without requiring a ROM from the Boktai trilogy. I have tested it in melonDS DS, and it works like a charm. The compressed logo data that's normally embedded in NDS and GBA carts is copied from the loaded NDS ROM in
NDS::Startif the Boktai stub is used.This PR (as of this writing) does not add this capability to the UI, but I can do so if you want me to.