Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude JIT-related declarations more aggressively #1907

Merged
merged 11 commits into from
Dec 8, 2023

Conversation

JesseTG
Copy link
Contributor

@JesseTG JesseTG commented Dec 6, 2023

This reduces the risk of linker errors occurring when building on ARM without the JIT.

@Adamillo
Copy link

Adamillo commented Dec 6, 2023

That makes me curious. Does this mean that someone could now theoretically use melonDS on ARMv7 aka 32-bit ARM with no JIT?

@JesseTG
Copy link
Contributor Author

JesseTG commented Dec 6, 2023

Dunno. This PR isn't intended to support new platforms, it just makes the build process for already-supported platforms less likely to break. That's what's been happening with melonDS DS.

@Adamillo
Copy link

Adamillo commented Dec 6, 2023

I see. The reason I ask is that on platforms like x86_32 you can use melonDS with the JIT disabled. I'd imagine that you'd be able to do the same with ARM32 now that the linker errors are fixed

@JesseTG
Copy link
Contributor Author

JesseTG commented Dec 6, 2023

Maybe. I've never tried to build melonDS (upstream, libretro core, or any other port) on 32-bit ARM. I suppose this PR would theoretically make that simpler by virtue of the reduced risk of breakage.

@RSDuck
Copy link
Member

RSDuck commented Dec 6, 2023

That makes me curious. Does this mean that someone could now theoretically use melonDS on ARMv7 aka 32-bit ARM with no JIT?

you could already do that before. Besides maybe some small slip up the JIT is fully disableable

@JesseTG
Copy link
Contributor Author

JesseTG commented Dec 6, 2023

And this PR fixes some sources of small slip-ups.

@nadiaholmquist nadiaholmquist merged commit 5dac65f into melonDS-emu:master Dec 8, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants