-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude JIT-related declarations more aggressively #1907
Exclude JIT-related declarations more aggressively #1907
Conversation
- If in NDS mode, return instead of `assert`ing - Use `static_cast` and `ConsoleType` instead of `dynamic_cast`
That makes me curious. Does this mean that someone could now theoretically use melonDS on ARMv7 aka 32-bit ARM with no JIT? |
Dunno. This PR isn't intended to support new platforms, it just makes the build process for already-supported platforms less likely to break. That's what's been happening with melonDS DS. |
I see. The reason I ask is that on platforms like x86_32 you can use melonDS with the JIT disabled. I'd imagine that you'd be able to do the same with ARM32 now that the linker errors are fixed |
Maybe. I've never tried to build melonDS (upstream, libretro core, or any other port) on 32-bit ARM. I suppose this PR would theoretically make that simpler by virtue of the reduced risk of breakage. |
you could already do that before. Besides maybe some small slip up the JIT is fully disableable |
And this PR fixes some sources of small slip-ups. |
This reduces the risk of linker errors occurring when building on ARM without the JIT.