Issue 675 unsubscribe - do not delete #680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue_675_subscription
GalGend
reviewed
Apr 29, 2023
server/api/lib/challanged-file.js
Outdated
| @@ -49,7 +49,7 @@ const downloadChallengedFile = (url, file, options, protocol) => { | |||
| } else { | |||
| // if we did get a cookie we completed the challenge successfuly and | |||
| // should use it to download the file | |||
| downloadChallengedFile(url, file, { | |||
| downloadChallengedFile(url, file, { // set cookie header | |||
GalGend
reviewed
Apr 29, 2023
GalGend
reviewed
Apr 29, 2023
server/api/lib/challanged-file.js
Outdated
| @@ -21,13 +21,13 @@ const downloadChallengedFile = (url, file, options, protocol) => { | |||
| // if we didn't get a cookie yet this is the first part of the challenge - | |||
| // the page source contains the javascript code we need to run and challenge | |||
| // paramters for the calculation | |||
| if (!('set-cookie' in response.headers)) { | |||
| if (!('set-cookie' in response.headers)) { | |||
GalGend
reviewed
Apr 29, 2023
| throw new Exception.NotFound('Nof found'); | ||
| } | ||
|
|
||
| Log.debug('unsubscribe request for alert id:', fetchedModel.get('id')); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.