updatePlanTags In Crawler Can Be Called From A Cron Job #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalGend
reviewed
Feb 7, 2022
| exports.up = function(knex) { | ||
| return knex.schema.table('plan', table => { | ||
| // some default time | ||
| table.dateTime('last_tags_update').notNullable().defaultTo('2000-01-01 00:00:01'); |
GalGend
approved these changes
Feb 7, 2022
GalGend
reviewed
Feb 7, 2022
| @@ -307,7 +307,6 @@ const updatePlanTags = async () => { | |||
| // Re-compute the tags of a plan if the last update time of the plan is after the last update time of the tags of this plan. | |||
| // Before re-computing the tags of a plan, remove all previous tags for this plan. | |||
|
|
|||
| // TODO: Loop on the plans that need to be updated | |||
| const plans = await Plan.getPlansToTag(); | |||
gruppin
reviewed
May 12, 2022
| } catch (err) { | ||
| Log.error(err); | ||
| Log.error('had a problem saving tags for plan ' + plan_id + '\n' + err); |
There was a problem hiding this comment.
Log.error(problem saving tags for plan ${plan_id} , err);
| @@ -307,7 +307,6 @@ const updatePlanTags = async () => { | |||
| // Re-compute the tags of a plan if the last update time of the plan is after the last update time of the tags of this plan. | |||
| // Before re-computing the tags of a plan, remove all previous tags for this plan. | |||
|
|
|||
| // TODO: Loop on the plans that need to be updated | |||
| const plans = await Plan.getPlansToTag(); | |||
| Log.info(`Processing ${plans.models.length} plans`); | |||
| for (const planOrder in plans.models) { | |||
There was a problem hiding this comment.
for await (const planOrder of plans.models) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the adjustments for updatePlanTags in order for us to call it from a cron job.
It updates the tags of the necessary plans only.
Closes #393