Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps - Docker-Compose #483 #496

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

DevOps - Docker-Compose #483 #496

wants to merge 10 commits into from

Conversation

raznegrin
Copy link
Collaborator

No description provided.

@raznegrin raznegrin requested review from GalGend and TomerMe2 January 15, 2022 15:37
@CLAassistant
Copy link

CLAassistant commented Jan 15, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ TomerMe2
❌ Raz Negrin


Raz Negrin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@TomerMe2
Copy link
Collaborator

Thanks for PR :)
I changed the database-service/Dockerfile to work with our username and password.
Things that should be done that I don't know how to do:

  1. Run the following commands in the SQL dockerfile, inside the SQL shell:
CREATE DATABASE meirim character set UTF8 collate utf8_bin;
SET GLOBAL sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY,',''));
  1. Make service/start.sh run:
    knex migrate:latest
  2. Forward the UI port, which is 3000 into the user's PC.
  3. Forward the API port, which is 3001 into the user's PC.
  4. Allow SSH connection into the service docker from localhost only, so we would have an easy time configure a remote interpeted. Make sure that this SSH port is not exposed from the machine to the internet.
  5. Remove the /service/api directory, I didn't know if I should remove it or if you need examples from it.
  6. Make the start.sh script to work with our server. For example, to run the server you need to cd into /server and not into /api.
  7. Integrate this PR's readme into Meirim's readme so everyone would know how to run these dockers and debug using them :)
  8. Test this configuration by going into localhost:3000 on a browser to see if Meirim is running locally.

Thanks a lot for your work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants