hod hasharon tree url fix (#753)

* hod hasharon tree url fix * better proxy failure logging
meirim-org · Nov 28, 2023 · 638b728 · 638b728
1 parent b916636
commit 638b728
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/api/lib/proxy.js b/server/api/lib/proxy.js
@@ -18,7 +18,7 @@ async function get(url, wait =5000) {
 		return response.data;
 	}
 	catch (err) {
-		console.error(`error in proxy for url ${url}`);
+		console.error(`error in proxy for url ${url}`, err);
 	}
 }
 module.exports = {

diff --git a/server/api/lib/trees/hod_hasharon_tree_permit.js b/server/api/lib/trees/hod_hasharon_tree_permit.js
@@ -50,7 +50,7 @@ async function parseTreesHtml(url) {
     const treePermit = {};
     dom(elem).find('td,th').each((idx, elem) => {
             const url = idx === 6 ? dom(elem).find('a').attr('href') : '';
-            if (url.length > 0) {
+            if (url && url.length > 0) {
                 treePermit['url'] = url.substr(1);
             }
       const value = dom(elem).text().trim();
@@ -92,7 +92,7 @@ function processRawPermits(rawPermits) {
           [TREES_PER_PERMIT]: treesPerPermit,
           [TOTAL_TREES]: totalTrees,
 
-          [TREE_PERMIT_URL]: 'https://www.hod-hasharon.muni.il' + raw['url'],
+          [TREE_PERMIT_URL]: raw['url'] ? 'https://www.hod-hasharon.muni.il' + raw['url'] : '',
         };
         const permit = new TreePermit(attributes);
         return permit;