Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twig extensions to work with Twig v3 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nicholasruunu
Copy link

No description provided.

@mente
Copy link
Collaborator

mente commented May 3, 2022

Can you also reflect your changes in composer.json? It looks like php version 5 is not supported anymore and twig v 3 is supported

@nicholasruunu nicholasruunu force-pushed the feature/twig3-support branch from c29b953 to 2aac776 Compare May 20, 2022 08:58
@nicholasruunu
Copy link
Author

nicholasruunu commented May 20, 2022

@mente Not sure what you mean, it should be covered by symfony/twig-bundle v5, not sure if it invalidates twig v2 use.
And PHP is already at ^7.2

edit: Oh, guess it was pretty weird not having twig as a requirement, updated, that's what you mean?
edit: Works in PHP 8, so updated to >=7.2

@nicholasruunu nicholasruunu force-pushed the feature/twig3-support branch from 2aac776 to 3a33162 Compare May 20, 2022 09:12
@nicholasruunu nicholasruunu force-pushed the feature/twig3-support branch from 3a33162 to a5ed707 Compare May 20, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants