Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle correctly when replica count is set to 0 #238

Closed
wants to merge 14 commits into from
Closed

feat: handle correctly when replica count is set to 0 #238

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5b52ba7
feat: handle correctly when replicas is set to 0
Tchoupinax Aug 22, 2024
16b67ac
chore: upgrade chart version
Tchoupinax Aug 22, 2024
e08273e
fix: bad value path
Tchoupinax Aug 22, 2024
7036faa
[CI] Syncing Helm manifest
brunoocasali Sep 9, 2024
5af7bb1
Merge branch 'main' into main
brunoocasali Sep 16, 2024
34ef980
[CI] Syncing Helm manifest
brunoocasali Sep 16, 2024
0277fb5
fix: revert replicas value to 1 by default
Tchoupinax Sep 16, 2024
4b04074
[CI] Syncing Helm manifest
brunoocasali Oct 2, 2024
7eaf827
Update meilisearch.yaml
brunoocasali Oct 2, 2024
e9856ae
[CI] Syncing Helm manifest
brunoocasali Oct 2, 2024
909de6b
Rollback change to keep 1 by default
brunoocasali Oct 2, 2024
7755203
[CI] Syncing Helm manifest
brunoocasali Oct 2, 2024
0abab9d
feat: set default replicas to 1
Tchoupinax Oct 3, 2024
355ace6
[CI] Syncing Helm manifest
brunoocasali Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions charts/meilisearch/Chart.yaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tchoupinax I can't look into why the CI is not working right now. Can you take a look at it, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/meilisearch/meilisearch-kubernetes/actions/runs/11145273451/job/30974493827

Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ apiVersion: v1
appVersion: "v1.10.0"
description: A Helm chart for the Meilisearch search engine
name: meilisearch
version: 0.10.1
version: 0.10.2
icon: https://raw.githubusercontent.com/meilisearch/integration-guides/main/assets/logos/logo.svg
home: https://github.com/meilisearch/meilisearch-kubernetes/tree/main/charts/meilisearch
maintainers:
- name: Bruno
email: [email protected]
- name: Clementine
email: [email protected]
- name: Bruno
email: [email protected]
- name: Clementine
email: [email protected]
6 changes: 6 additions & 0 deletions charts/meilisearch/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ metadata:
labels:
{{- include "meilisearch.labels" . | nindent 4 }}
spec:
# Value 0 is bad interpreted it goes to 1 by default
# https://github.com/helm/helm/issues/3164
{{- if (eq 0 (int .Values.replicaCount))}}
replicas: 0
{{- else }}
replicas: {{ .Values.replicaCount | default 1 }}
{{- end }}
serviceName: {{ template "meilisearch.fullname" . }}
selector:
matchLabels:
Expand Down
6 changes: 4 additions & 2 deletions manifests/meilisearch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ metadata:
app.kubernetes.io/component: search-engine
app.kubernetes.io/part-of: meilisearch
spec:
replicas: 1
# Value 0 is bad interpreted it goes to 1 by default
# https://github.com/helm/helm/issues/3164
replicas: 0
Tchoupinax marked this conversation as resolved.
Show resolved Hide resolved
brunoocasali marked this conversation as resolved.
Show resolved Hide resolved
serviceName: meilisearch
selector:
matchLabels:
Expand All @@ -75,7 +77,7 @@ spec:
app.kubernetes.io/component: search-engine
app.kubernetes.io/part-of: meilisearch
annotations:
checksum/config: 57066f343c11bb744192756429e406248806cda981bd4a71c7c02dcafc103072
checksum/config: 3b17fd234a29aacf2e98ffa09aca207fa5519140923bc64b656070f54412fe1f
spec:
serviceAccountName: meilisearch
securityContext:
Expand Down