Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reintroduce the possibility to specify a replicaCount in values.yaml #199

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

jlandic
Copy link
Contributor

@jlandic jlandic commented Sep 19, 2023

Pull Request

What does this PR do?

  • Re-enable the possibility to customize the spec.replicas value of the StatefulSet, a requirement we have for our internal High Availability tests.
  • Keep a default value of 1 replica to match the most common uses.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@jlandic jlandic marked this pull request as ready for review September 19, 2023 14:48
@jlandic jlandic requested a review from alallema September 19, 2023 14:48
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @jlandic, and your first PR on this repo ✨
LGTM! 🔥

@alallema
Copy link
Contributor

bors merge

@jlandic
Copy link
Contributor Author

jlandic commented Sep 19, 2023

happy_seal

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 19, 2023

Build succeeded:

@jlandic jlandic merged commit e0dfc23 into main Sep 19, 2023
3 checks passed
@jlandic jlandic deleted the feat-reintroduce-customizable-replicacount-with-default branch September 19, 2023 15:18
@mike-code
Copy link

So just to confirm, even though it's a variable, it shouldn't be used?

@brunoocasali
Copy link
Member

brunoocasali commented Apr 4, 2024

So just to confirm, even though it's a variable, it shouldn't be used?

@mike-code Yes, you're right, Meilisearch is not highly available yet, so if you create more replicas you will end up with inconsistencies between the replica's data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants