Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replicas have 1 hardcoded #193

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

damieneichhorn
Copy link

Pull Request

Related issue

Fixes #188

What does this PR do?

  • set replicaCount to a hardcoded 1
  • remove replicaCount from default values file

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@damieneichhorn damieneichhorn changed the title make replicas have 1 hardcoded Make replicas have 1 hardcoded Aug 28, 2023
brunoocasali
brunoocasali previously approved these changes Aug 28, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me @alallema

@damieneichhorn
Copy link
Author

@meilisearch sync-manifest

1 similar comment
@damieneichhorn
Copy link
Author

@meilisearch sync-manifest

@damieneichhorn
Copy link
Author

@brunoocasali it seems the sync-manifest command is erroring with the following error: Request failed with error TypeError: Cannot read properties of undefined (reading 'get')

@brunoocasali brunoocasali requested a review from alallema August 29, 2023 13:03
@alallema
Copy link
Contributor

Hi @damieneichhorn

@brunoocasali it seems the sync-manifest command is erroring with the following error: Request failed with error TypeError: Cannot read properties of undefined (reading 'get')

Yes, it's possible that the GitHub action doesn't work correctly for people who don't have rights on the repo. Sorry about that I allow myself to update the manifest

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @damieneichhorn for this PR!
LGTM! But at the time I agreed with the issue I didn't have the information that the HA (High Availability) might be coming out soon. So I'm wondering if it's worth modifying the chart now.
I'll let @brunoocasali decide about it

@brunoocasali
Copy link
Member

Let's merge it @alallema since we don't have a clear path of how our Meili version of the HA will look yet.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Aug 31, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit fab2ae5 into meilisearch:main Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the possibility to set replicaCount to a value other than "1"?
3 participants