Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add debug mode and refactor print_notifs #84

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

LangLangBart
Copy link
Collaborator

@LangLangBart LangLangBart commented Apr 11, 2024

description

# For example, the file will catch all stdout and stderr, as well as everything from 'xtrace'
GH_NOTIFY_DEBUG_MODE='true' gh notify -an 20
[DEBUG] /Users/paria/.local/share/gh/extensions/gh-notify/gh_notify_debug.log
  • Split the 'print_notifs' into smaller functions for readability.

  • Fix retrieval for notifications with more than 50 items requested; previously, it would just
    ignore them and deliver only 50.

  • Prepend command to all command calls

# Execute the `cat` command, even if an `cat` alias exists:
command cat
  • Check if bat or batcat is installed for diffs on PR's

  • Clarify user facing texts

@LangLangBart LangLangBart changed the title refactor: split print_notifs into smaller functions refactor: Add debug mode and refactor print_notifs Apr 12, 2024
@LangLangBart LangLangBart merged commit dce9a68 into main Apr 19, 2024
1 check passed
@LangLangBart LangLangBart deleted the split_print_notifs branch April 19, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants