Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjust abbreviation lengths and version checking logic #82

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

LangLangBart
Copy link
Collaborator

@LangLangBart LangLangBart commented Mar 16, 2024

description

Corrected the version update check, as it previously gave false positives when a user's version was
higher overall, but lower in subsequent parts.

Adjust the abbreviation length for the repo names

Update docs

Miscellaneous

Fix #81 update demo.mp4

demo.mp4

@LangLangBart
Copy link
Collaborator Author

LangLangBart commented Mar 17, 2024

I plan to merge at the beginning of next week. I also want to add some tests, but I haven't decided on a testing framework yet.


Requirements:

  1. Simple installation command, no plugins required
  2. Ability to mock all three possibilities: alias, function export, and PATH override
  3. Sufficient failure reporting

Bats

  • Does not meet my third requirement, as the expected value is not shown by default

shUnit2

  • Does not meet my second requirement, lacks function exports for mocking

bash_unit (not tested yet)

bashunit (not tested yet)

ShellSpec

  • Test writing syntax is unintuitive

shpec

  • Last commit was 5 years ago

bach

  • requires bash version >=4.3, macOS still comes with bash 3.2 by default

@LangLangBart LangLangBart merged commit 0d8fa37 into main Mar 19, 2024
1 check passed
@LangLangBart LangLangBart deleted the fixes branch March 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update demo following #79
1 participant